worryg0d commented on code in PR #1773:
URL: 
https://github.com/apache/cassandra-gocql-driver/pull/1773#discussion_r1766743063


##########
conn.go:
##########
@@ -215,6 +216,14 @@ type Conn struct {
        host            *HostInfo
        isSchemaV2      bool
 
+       // Only for proto v5+.
+       // Indicates if Conn is ready to use Native Protocol V5.

Review Comment:
   I agree. I changed the comment and renamed the flag to `startupCompleted`.
   ```
        // Only for proto v5+.
        // Indicates if STARTUP has been completed.
        // github.com/apache/cassandra/blob/trunk/doc/native_protocol_v5.spec
        // 2.3.1 Initial Handshake
        //      In order to support both v5 and earlier formats, the v5 framing 
format is not
        //  applied to message exchanges before an initial handshake is 
completed.
        startupCompleted bool
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to