tolbertam commented on code in PR #1935:
URL:
https://github.com/apache/cassandra-java-driver/pull/1935#discussion_r1767795428
##########
core/src/main/java/com/datastax/oss/driver/api/core/type/codec/TypeCodec.java:
##########
@@ -216,6 +216,17 @@ default boolean accepts(@NonNull DataType cqlType) {
@NonNull
String format(@Nullable JavaTypeT value);
+ /**
+ * Formats items from collection type as valid list of CQL literals.
+ *
+ * <p>Implementing this method is not strictly mandatory. Default
implementation falls back to
+ * {@code #format(JavaTypeT)}. Method is used primarily for literal values
in the query builder
Review Comment:
```suggestion
* {@link #format(JavaTypeT)}. Method is used primarily for literal values
in the query builder
```
##########
core/src/main/java/com/datastax/oss/driver/api/core/type/codec/TypeCodec.java:
##########
@@ -216,6 +216,17 @@ default boolean accepts(@NonNull DataType cqlType) {
@NonNull
String format(@Nullable JavaTypeT value);
+ /**
+ * Formats items from collection type as valid list of CQL literals.
+ *
+ * <p>Implementing this method is not strictly mandatory. Default
implementation falls back to
+ * {@code #format(JavaTypeT)}. Method is used primarily for literal values
in the query builder
+ * (see {@code DefaultLiteral#appendElementsTo(StringBuilder)}.
Review Comment:
```suggestion
* (see {@code DefaultLiteral#appendElementsTo(StringBuilder)}).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
