absurdfarce commented on code in PR #1826: URL: https://github.com/apache/cassandra-gocql-driver/pull/1826#discussion_r1773661468
########## README.md: ########## @@ -19,8 +19,8 @@ The following matrix shows the versions of Go and Cassandra that are tested with | Go/Cassandra | 4.0.x | 4.1.x | |--------------|-------|-------| -| 1.19 | yes | yes | -| 1.20 | yes | yes | +| 1.22 | yes | yes | +| 1.23 | yes | yes | Gocql has been tested in production against many versions of Cassandra. Due to limits in our CI setup we only test against the latest 2 GA releases. Review Comment: I believe that's correct @taaraora. I fully expect the existing functionality of gocql will work pretty well with Cassandra 5.0.x. What concerns me is [CASSANDRA-19906](https://issues.apache.org/jira/browse/CASSANDRA-19906). We've been adding support for Cassandra 5.0.x to our test matrices for the other drivers DataStax maintains and we've hit an issue with precisely this problem on every one of them. The PR you reference doesn't have this concern because it also moves to testcontainers, but that's a change (a) I'm not entirely sold on and (b) I certainly don't want to take on in order to get 1.7.0 out the door. Given all of that I was fine leaving 5.0.0 out for now. There's a [fix](https://github.com/apache/cassandra/commit/971747e3e25b7dec6a8ed50ed56ac0d14a3de6b1) to that issue coming in 5.0.1 so (barring some other major issue) I'd be fine with adding 5.0.1 to the existing setup once it's officially released (the vote is going on as I write this). Make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
