dcapwell commented on code in PR #125:
URL: https://github.com/apache/cassandra-accord/pull/125#discussion_r1775675373
##########
accord-core/src/test/java/accord/utils/Property.java:
##########
@@ -708,6 +708,8 @@ public interface Setup<State, SystemUnderTest>
private final Map<Setup<State, SystemUnderTest>, Integer> knownWeights
= new LinkedHashMap<>();
@Nullable
private Set<Setup<State, SystemUnderTest>> unknownWeights = null;
+ @Nullable
+ private Map<Predicate<State>, List<Setup<State, SystemUnderTest>>>
conditionalCommands = null;
Review Comment:
some of the stateful tests were flakey due to too many selections that were
told to be `Ignored`... so avoid that by only including them *when* their
predicate matches... this optimization was known at the time of writing this
class, but going with a simpler one was selected as things were stable...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
