aweisberg commented on code in PR #3568:
URL: https://github.com/apache/cassandra/pull/3568#discussion_r1779664642
##########
src/java/org/apache/cassandra/service/StorageProxy.java:
##########
@@ -2267,7 +2324,28 @@ public static PartitionIterator
readRegular(SinglePartitionReadCommand.Group gro
long start = nanoTime();
try
{
- PartitionIterator result = fetchRows(group.queries,
consistencyLevel, coordinator, requestTime);
+ ClusterMetadata cm = ClusterMetadata.current();
+ TableId tableId = group.queries.get(0).metadata().id;
+ // Returns null for local tables
+ TableMetadata tableMetadata = getTableMetadata(cm, tableId);
+ if (tableMetadata == null)
+ tableMetadata =
Schema.instance.localKeyspaces().getTableOrViewNullable(tableId);
+ TableParams tableParams = tableMetadata.params;
+
+ TransactionalMode transactionalMode =
tableParams.transactionalMode;
+ TransactionalMigrationFromMode transactionalMigrationFromMode =
tableParams.transactionalMigrationFrom;
+ if (transactionalMigrationFromMode !=
TransactionalMigrationFromMode.none && transactionalMode.readsThroughAccord &&
transactionalMigrationFromMode.writesThroughAccord() &&
transactionalMigrationFromMode.readsThroughAccord())
Review Comment:
I think this is just 100% wrong, and I'll also bet that if this thing
actually worked it would have made a bunch of the tests fail when we test live
migration to full.
We don't have the looping and splitting to handle races and route different
parts of the query to Accord/Cassandra so really no migration should be allowed.
I think for today we should just remove this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
