tolbertam commented on code in PR #3602:
URL: https://github.com/apache/cassandra/pull/3602#discussion_r1794248915
##########
src/java/org/apache/cassandra/auth/IAuthenticator.java:
##########
@@ -54,6 +57,17 @@ public interface IAuthenticator
*/
void setup();
+ /**
+ * Allows custom authenticators to return a {@link AuthenticateMessage}
with a known
+ * authenticator implementation (e.g.
"com.datastax.bdp.cassandra.auth.DseAuthenticator"
+ * which enables SASL scheme negotiation) based on {@link Connection} and
{@link ClientState}
+ * information.
+ */
+ default AuthenticateMessage getAuthenticateMessage(Connection connection,
ClientState clientState)
Review Comment:
Agreed, I think passing only `ClientState` would be sufficient. If someone
finds that sufficiently lacking, they could update `ClientState` to include
what they need, without having to change the `IAuthenticator` interface :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
