absurdfarce commented on PR #1964: URL: https://github.com/apache/cassandra-java-driver/pull/1964#issuecomment-2404281798
I very much like your idea of creating CqlLiteral as a standalone class @lukasz-antoniak. But as I was looking this over again earlier today I started wondering about a few things. First off: I started worrying if CqlLiteral sitting right next to the default impl of the Literal interface (DefaultLiteral) would be confusing; they have very similar names but don't really have anything in common. That in turn got me wondering... is there some way we can do this with just Literal (via QueryBuilder.literal())? We have to tweak a few things; OptionsUtils relies entirely on StringBuilder.append() which means DefaultLiteral needs a good toString() (it doesn't define it's own currently) but if we get the right thing there DefaultLiteral is also not an instance of String so (hypothetically) OptionsUtils.extractOptionValue() won't quote it. I haven't been able to make this work yet but I wanna muck around with it a bit more before I write off the idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
