worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1802855644
##########
frame.go:
##########
@@ -1503,18 +1523,21 @@ func (f *framer) writeQueryParams(opts *queryParams) {
}
}
- if opts.keyspace != "" {
- if f.proto > protoVersion4 {
+ // protoV5 specific things
+ if f.proto > protoVersion4 {
+ if opts.keyspace != "" {
flags |= flagWithKeyspace
- } else {
- panic(fmt.Errorf("the keyspace can only be set with
protocol 5 or higher"))
Review Comment:
Now I'm looking at it and releasing that that was a bit greedy decision to
get rid of those panics. I'll change this one too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
