worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1803350428
##########
conn.go:
##########
@@ -474,8 +483,12 @@ func (s *startupCoordinator) startup(ctx context.Context,
supported map[string][
case error:
return v
case *readyFrame:
+ // Connection is successfully set up and ready to use Native
Protocol v5
+ s.conn.startupCompleted = true
Review Comment:
Removing it from the **Conn** object and passing its value explicitly to
`recv()` may cause some problems at the startup phase because it runs its own
reading goroutine which we should notify when it should use native proto v5
when it comes to parsing **AUTHENTICATE** response message:
```
go func() { // the reading goroutine
for range s.frameTicker {
err := s.conn.recv(ctx)
if err != nil {
...
}
}
}()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
