michaelsembwever commented on code in PR #3548: URL: https://github.com/apache/cassandra/pull/3548#discussion_r1806672848
########## src/java/org/apache/cassandra/tools/nodetool/CompareGossipAndServiceCache.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.cassandra.tools.nodetool; + +import io.airlift.airline.Command; +import org.apache.cassandra.tools.NodeProbe; +import org.apache.cassandra.tools.NodeTool.NodeToolCmd; + +@Command(name = "comparegossipandservicecache", description = "compares the Gossip and Storage service cache; returns true if they are in sync, false otherwise") +public class CompareGossipAndServiceCache extends NodeToolCmd +{ + @Override + public void execute(NodeProbe probe) + { + /** Cassandra maintains the Gossip info (Token, Status, etc.) in two caches 1) Gossip cache 2) Storage Service cache Review Comment: nit: can we refer to these by their correct names please, Gossip (endpoint) state and TokenMetadata. The Gossip state is a probabilistic view of the cluster (optimistic updates every second), and TokenMetadata a cache of the resulting topology view that's usable by the hotpaths (e.g. read and write requests). The design of token metadata intends non-consistent guarantees, but the implementation can ofc have bugs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
