dcapwell commented on code in PR #3621:
URL: https://github.com/apache/cassandra/pull/3621#discussion_r1806961235
##########
test/unit/org/apache/cassandra/db/marshal/AbstractTypeTest.java:
##########
@@ -460,6 +460,31 @@ public void nested()
});
}
+ @Test
+ @SuppressWarnings("rawtypes")
+ public void nestedDuration()
+ {
+
qt().forAll(AbstractTypeGenerators.builder().withoutTypeKinds(PRIMITIVE,
COUNTER).withPrimitives(DurationType.instance).build()).checkAssert(type -> {
+ assertThat(type.referencesDuration()).isTrue();
+ });
+ }
+
+ @Test
+ public void nestedWithoutDuration()
+ {
+
qt().forAll(AbstractTypeGenerators.builder().withoutTypeKinds(PRIMITIVE,
COUNTER).withoutPrimitive(DurationType.instance).build()).checkAssert(type -> {
+ assertThat(type.referencesDuration()).isFalse();
+ });
+ }
+
+ @Test
+ public void nonDurationPrimitives()
Review Comment:
this is the same test as `nestedWithoutDuration`, can you delete?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
