jaydeepkumar1984 commented on PR #3598: URL: https://github.com/apache/cassandra/pull/3598#issuecomment-2427154086
Thanks, @masokol, for the review! Please find my response here: > - Combine ranges instead of splitting - in ecChronos we saw huge improvements in some scenarios (when the data is low or empty tables) compared to repairing 1 vnode at a time. This improvement scaled with amount of vnodes, although it might've been related to overhead due to running repairs through JMX. Not sure but might be worth investigating. 1. Generally, empty tables or tables with a small amount of data runs through pretty fast, in seconds, so it is not a major issue for smaller/empty tables. 2. The current framework already has support to combine ranges through a setting ([src/java/org/apache/cassandra/repair/autorepair/AutoRepair.java:266](https://github.com/apache/cassandra/pull/3598/files#diff-b9a857a0f20a2f239d5e27511e4db19c87704faccb17b5205b5406e69ea08f52R266)) > - Major versions, during major version upgrades like 3 -> 4 we weren't supposed to run repairs. If Cassandra plans to keep this then it would be nice for repairs to automatically pause during major version upgrades. This is a great suggestion, and the framework can be enhanced easily - I just filed a new sub-ticket [CASSANDRA-20013](https://issues.apache.org/jira/browse/CASSANDRA-20013) to track this > - Observabliity, i saw there're metrics but it would also be nice to see repair status with nodetool. There is already a new nodetool command that would print the current status. Please take a look at it [here](https://docs.google.com/document/d/1CJWxjEi-mBABPMZ3VWJ9w5KavWfJETAGxfUpsViPcPo/edit?tab=t.0#bookmark=id.887cdlihznq7). - Repair priority per table, not per node. Currently, it will repair the tables randomly, but it can be enhanced to add a priority as a CQL table property that an end user can configure, which can also be enhanced easily. Just added this enhancement to the ticket mentioned above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
