worryg0d commented on code in PR #1822:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1822#discussion_r1809230661
##########
conn.go:
##########
@@ -694,7 +718,7 @@ func (c *Conn) recv(ctx context.Context) error {
} else if head.stream == -1 {
// TODO: handle cassandra event frames, we shouldnt get any
currently
framer := newFramer(c.compressor, c.version)
- if err := framer.readFrame(c, &head); err != nil {
+ if err := framer.readFrame(r, &head); err != nil {
return err
}
go c.session.handleEvent(framer)
Review Comment:
I updated the impl of
[ConnReader](https://github.com/worryg0d/gocql/commit/bc29d6e491e75fd72f0c77445151dc117d62ac02).
The only thing I don't like here is that
[calling](https://github.com/worryg0d/gocql/blob/bc29d6e491e75fd72f0c77445151dc117d62ac02/conn.go#L567C1-L569C2)
`Close()` on the `r` actually closes the whole `net.Conn`. We should probably
move `contextWriter` from `Conn` to the wrapper as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
