aweisberg commented on code in PR #3632:
URL: https://github.com/apache/cassandra/pull/3632#discussion_r1815608568
##########
src/java/org/apache/cassandra/tcm/AtomicLongBackedProcessor.java:
##########
@@ -177,17 +177,17 @@ public synchronized EntryHolder getEntries(Epoch since,
Epoch until)
public LogState getLogState(Epoch start, Epoch end)
{
EntryHolder state = getEntries(Epoch.EMPTY);
- ClusterMetadata metadata = new
ClusterMetadata(DatabaseDescriptor.getPartitioner());;
+ ClusterMetadata metadata = new
ClusterMetadata(DatabaseDescriptor.getPartitioner());
Iterator<Entry> iter = state.iterator();
ImmutableList.Builder<Entry> rest = new ImmutableList.Builder<>();
while (iter.hasNext())
{
Entry current = iter.next();
if (current.epoch.isAfter(end))
break;
- if (current.epoch.isEqualOrBefore(start))
+ if (current.epoch.isDirectlyAfter(metadata.epoch))
Review Comment:
`metadata.epoch` will always be 0 here right? So what happens if start is
not 0? How can a transformation that doesn't start from the beginning work on
an empty epoch when the transformation is supposed to operate on one that is
not empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
