lukasz-antoniak commented on code in PR #1828:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1828#discussion_r1819014410
##########
helpers.go:
##########
@@ -236,19 +274,48 @@ func splitCompositeTypes(name string) []string {
}
func apacheToCassandraType(t string) string {
- t = strings.Replace(t, apacheCassandraTypePrefix, "", -1)
t = strings.Replace(t, "(", "<", -1)
t = strings.Replace(t, ")", ">", -1)
types := strings.FieldsFunc(t, func(r rune) bool {
return r == '<' || r == '>' || r == ','
})
- for _, typ := range types {
- t = strings.Replace(t, typ,
getApacheCassandraType(typ).String(), -1)
+ skip := 0
+ for _, class := range types {
+ class = strings.TrimSpace(class)
+ if !isDigitsOnly(class) {
Review Comment:
Updated the code. Hope this is what you had in mind. I had to leave
`isDigitsOnly` function not to update vector dimension to `custom`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
