smiklosovic commented on code in PR #3644:
URL: https://github.com/apache/cassandra/pull/3644#discussion_r1824717738
##########
src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java:
##########
@@ -1333,7 +1333,7 @@ public void cacheKey(DecoratedKey key, RowIndexEntry info)
{
CachingParams caching = metadata().params.caching;
- if (!caching.cacheKeys() || keyCache == null || keyCache.getCapacity()
== 0)
+ if (!caching.cacheKeys() || keyCache == null || !keyCache.enabled())
Review Comment:
if we made "enabled" static and its capacity is set in runtime to 0 then it
would not return here, would it? So it means that we would continue with the
logic while we could work with a cache where capacity is 0. That does not make
sense to me ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
