maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1826432732
##########
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##########
@@ -182,8 +182,9 @@ static Set<String> asSet()
{
Set<String> valueSet = new HashSet<>();
ConfigKey[] values = values();
- for(ConfigKey key: values) {
- valueSet.add(key.getKeyName().toLowerCase());
+ for (ConfigKey key : values)
+ {
+ valueSet.add(key.toString().toLowerCase());
Review Comment:
Can we leave this until all other comments are resolved from you and other
reviewers? Based on my past experience, I would take the latest trunk and
reapply all the changes vs rebasing to keep commit history clear on this PR. I
can pick this up as the last step after rebasing. Will leave this comment
unresolved until then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
