sarankk commented on code in PR #145:
URL: https://github.com/apache/cassandra-sidecar/pull/145#discussion_r1831557658
##########
vertx-auth-mtls/src/main/java/io/vertx/ext/auth/mtls/CertificateIdentityExtractor.java:
##########
@@ -40,8 +42,8 @@ public interface CertificateIdentityExtractor
* </ul>
*
* @param certificateCredentials certificate chain of user that is already
verified
- * @return {@code String} identity string extracted from certificate,
uniquely represents client
+ * @return list of valid identities extracted from certificate.
* @throws CredentialValidationException when a valid identity cannot be
extracted from certificate chain.
*/
- String validIdentity(CertificateCredentials certificateCredentials) throws
CredentialValidationException;
+ List<String> validIdentities(CertificateCredentials
certificateCredentials) throws CredentialValidationException;
Review Comment:
Sometimes we could extract multiple identities from a certificate. If there
are multiple spiffe(s) listed in SAN, or just from multiple SAN entries we
could extract different identities. Hence we need to return a list rather than
a single identity from cert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
