smiklosovic commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1832194736
##########
src/java/org/apache/cassandra/config/EncryptionOptions.java:
##########
@@ -182,8 +182,9 @@ static Set<String> asSet()
{
Set<String> valueSet = new HashSet<>();
ConfigKey[] values = values();
- for(ConfigKey key: values) {
- valueSet.add(key.getKeyName().toLowerCase());
+ for (ConfigKey key : values)
+ {
+ valueSet.add(key.toString().toLowerCase());
Review Comment:
@maulin-vasavada
Your branch contains merge commits etc, that will not be deliverable on the
merge. It has to be just one commit. I put all the changes into this branch.
https://github.com/instaclustr/cassandra/commit/1d172ce58f2587ab521696e6037ae8ab6bc16c94
you can hard reset all your changes in your branch and cherry-pick that one
commit and force-push it to your remote to be on par with it.
Please create one commit for this branch so everybody has easier life.
The way I did that is that I did "git rebase trunk" while on this branch you
just pushed. There was one conflict I resolved. After that I just force-pushed
and got that commit above. You can do the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
