maedhroz commented on code in PR #3645:
URL: https://github.com/apache/cassandra/pull/3645#discussion_r1833420630
##########
test/distributed/org/apache/cassandra/distributed/test/sai/StrictFilteringTest.java:
##########
@@ -68,9 +65,7 @@ public void shouldRejectNonStrictIN()
String select = withKeyspace("SELECT * FROM %s.reject_in WHERE a = 1
AND b IN (2, 3) ALLOW FILTERING");
- // This should fail, as strict filtering is not allowed:
- Assertions.assertThatThrownBy(() ->
CLUSTER.coordinator(1).execute(select, ConsistencyLevel.ALL))
-
.hasMessageContaining(String.format(StorageAttachedIndexQueryPlan.UNSUPPORTED_NON_STRICT_OPERATOR,
Operator.IN));
+ assertRows(CLUSTER.coordinator(1).execute(select,
ConsistencyLevel.ALL), row(0,1,2));
Review Comment:
Two notes:
1.) We can probably rename the test something like
`shouldPostFilterNonStrictIN`
2.) We don't really need the index on `b` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
