ifesdjeen commented on code in PR #133:
URL: https://github.com/apache/cassandra-accord/pull/133#discussion_r1833988261
##########
accord-core/src/main/java/accord/local/Cleanup.java:
##########
@@ -200,7 +201,10 @@ private static Cleanup cleanupWithFullRoute(boolean
isPartial, StoreParticipants
return Cleanup.NO;
case SHARD_REDUNDANT:
if (!isPartial && saveStatus.hasBeen(PreCommitted) &&
!saveStatus.hasBeen(Applied) && redundantBefore.preBootstrapOrStale(txnId,
participants.owns) != FULLY)
- illegalState("Loading redundant command that has been
PreCommitted but not Applied.");
+ {
+ agent.onViolation(String.format("Loading decided and
SHARD_REDUNDANT command (%s,%s) that has not been Applied. Expected to be
witnessed and executed by %s.", txnId, saveStatus,
redundantBefore.max(participants.route, e ->
e.shardAppliedOrInvalidatedBefore)));
Review Comment:
Could you take a look at that sentence? "Loading decided and SHARD_REDUNDANT
command (%s,%s) that has not been Applied" - somehow I can't parse it with
"and" here.
##########
accord-core/src/main/java/accord/local/RedundantBefore.java:
##########
@@ -68,6 +68,21 @@ public static RedundantBefore create(boolean inclusiveEnds,
RoutingKey[] ends, E
public enum PreBootstrapOrStale { NOT_OWNED, FULLY, PARTIALLY,
POST_BOOTSTRAP }
+// public static class OwnershipEntry
Review Comment:
Nit: looks like this can go away now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
