yifan-c commented on code in PR #145:
URL: https://github.com/apache/cassandra-sidecar/pull/145#discussion_r1837355258
##########
server/src/main/java/org/apache/cassandra/sidecar/acl/AuthCache.java:
##########
@@ -155,10 +163,7 @@ protected void warm(int availableRetries)
catch (Exception e)
{
LOGGER.warn("Unexpected error encountered during pre-warming of
cache={} ", name, e);
- vertx.setTimer(config.warmupRetryIntervalMillis(), t ->
internalPool.executeBlocking(() -> {
- warm(availableRetries - 1);
- return null;
- }));
+ vertx.setTimer(config.warmupRetryIntervalMillis(), t ->
warmUp(availableRetries - 1));
Review Comment:
I think you want to call `warmUpAsync` to keep the behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
