belliottsmith commented on code in PR #3664:
URL: https://github.com/apache/cassandra/pull/3664#discussion_r1837655455


##########
src/java/org/apache/cassandra/service/accord/AccordConfigurationService.java:
##########
@@ -381,7 +381,7 @@ public synchronized void onNodesRemoved(long epoch, 
Topology current, Set<Node.I
     private long[] nonCompletedEpochsBefore(long max)

Review Comment:
   We can prune, so min epoch can move also. This is only called in tests 
today, but the method exists (and will be used in production), so we should not 
break it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to