OleksiienkoMykyta commented on code in PR #1821:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1821#discussion_r1837863650
##########
cluster.go:
##########
@@ -102,7 +102,8 @@ type ClusterConfig struct {
// Initial keyspace. Optional.
Keyspace string
- // Number of connections per host.
+ // The size of connection pool for each host. The Pool will be filled
during the first request execution.
Review Comment:
You are right!
I double-checked it with the timeout, and it turned out that the pool filled
during initialization. When I tested it last time the pool had not been filled
before the query execution because [pool filling runs in separate
gorutine](https://github.com/OleksiienkoMykyta/gocql/blob/974fa1211ccef10a418966fd7b00984a39ed9232/session.go#L292)
and it took more time to finish than the query execution.
Thank you for noticing the issue!
I can replace it with something like
```
The size of the connection pool for each host. The pool filling runs in
separate gourutine during the session initialization phase.
Also, it describes a maximum number of connections at the same time.
Notice: There is no guarantee that pool filling will be finished in the
initialization phase.
Default: 2
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
