belliottsmith commented on code in PR #3463:
URL: https://github.com/apache/cassandra/pull/3463#discussion_r1837906146
##########
src/java/org/apache/cassandra/service/accord/txn/TxnData.java:
##########
@@ -40,18 +41,77 @@
* Fairly generic holder for result values for Accord txns as well as data
exchange during Accord txn execution
* when read results are returned to the coordinator to compute query results
and writes.
*/
-public class TxnData extends HashMap<TxnDataName, TxnDataValue> implements
TxnResult, Data
+public class TxnData extends Int2ObjectHashMap<TxnDataValue> implements
TxnResult, Data
{
private static final long EMPTY_SIZE = ObjectSizes.measure(new TxnData());
+ private static final int TXN_DATA_NAME_INDEX_BITS = 32 - 6;
Review Comment:
Also, not important, but if we use the lower bits for kind we can encode as
a `vint` which I would expect to normally be a single byte.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
