joao-r-reis commented on code in PR #1790:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1790#discussion_r1838296767
##########
cluster.go:
##########
@@ -189,12 +189,12 @@ type ClusterConfig struct {
// set to 10.0.0.1 which is what will be used to connect to.
IgnorePeerAddr bool
- // If DisableInitialHostLookup then the driver will not attempt to get
host info
+ // If DisableHostLookup then the driver will not attempt to get host
info
// from the system.peers table, this will mean that the driver will
connect to
// hosts supplied and will not attempt to lookup the hosts information,
this will
// mean that data_centre, rack and token information will not be
available and as
// such host filtering and token aware query routing will not be
available.
- DisableInitialHostLookup bool
+ DisableHostLookup bool
Review Comment:
At the very least we would have to keep both flags (and deprecate the old
one) and map it to a single internal flag so that we can do a "safe" rename of
the flag without breaking user applications.
##########
cluster.go:
##########
@@ -189,12 +189,12 @@ type ClusterConfig struct {
// set to 10.0.0.1 which is what will be used to connect to.
IgnorePeerAddr bool
- // If DisableInitialHostLookup then the driver will not attempt to get
host info
+ // If DisableHostLookup then the driver will not attempt to get host
info
// from the system.peers table, this will mean that the driver will
connect to
// hosts supplied and will not attempt to lookup the hosts information,
this will
// mean that data_centre, rack and token information will not be
available and as
// such host filtering and token aware query routing will not be
available.
- DisableInitialHostLookup bool
+ DisableHostLookup bool
Review Comment:
At the very least we would have to keep both flags (+ deprecate the old one)
and map it to a single internal flag so that we can do a "safe" rename of the
flag without breaking user applications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
