OleksiienkoMykyta commented on PR #1837: URL: https://github.com/apache/cassandra-gocql-driver/pull/1837#issuecomment-2470927308
> > @joao-r-reis I had an idea to implement it as you said in the first option, but it's the breaking changes, so I decided to keep backward compatibility. In case this feature is added to v2, there is no reason to leave `SerialConsistency`. I added the check to make sure that consistency is valid. > > Hmm what about if we have `type SerialConsistency = Consistency` like you did on this PR AND we replace all references of the `SerialConsistency` type (on parameters etc.) to `Consistency`? In this scenario I don't think there will be a breaking change. And we can mark `SerialConsistency` as `deprecated` I like this idea, it will solve the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
