belliottsmith commented on code in PR #138:
URL: https://github.com/apache/cassandra-accord/pull/138#discussion_r1844364332
##########
accord-core/src/main/java/accord/coordinate/CoordinateEphemeralRead.java:
##########
@@ -136,6 +136,6 @@ void onPreAccepted(Topologies topologies)
{
Deps deps = Deps.merge(oks, oks.domainSize(), SortedListMap::getValue,
ok -> ok.deps);
topologies = node.topology().reselect(topologies,
QuorumEpochIntersections.preaccept.include, route, executeAtEpoch,
executeAtEpoch, Owned);
- new ExecuteEphemeralRead(node, topologies, route, txnId, txn,
executeAtEpoch, deps, this).start();
+ new ExecuteEphemeralRead(node, topologies, route,
txnId.withEpoch(executeAtEpoch), txn, executeAtEpoch, deps, this).start();
Review Comment:
ephemeral reads chase an epoch they can validly execute in. For simplicity,
we define the txnId = executeAt, and so to execute in a future epoch we simply
make txnId.epoch == executeAt.epoch. This change was already made, but somehow
this codepath lost(?) the update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
