maedhroz commented on code in PR #3689:
URL: https://github.com/apache/cassandra/pull/3689#discussion_r1847359166
##########
test/distributed/org/apache/cassandra/fuzz/sai/SingleNodeSAITestBase.java:
##########
@@ -327,22 +223,31 @@ protected void repair(SchemaSpec schema)
protected void waitForIndexesQueryable(SchemaSpec schema) {}
- private static Relation.RelationKind pickKind(EntropySource random,
List<List<Relation.RelationKind>> options, int column)
+ public static Consumer<IInstanceConfig> defaultConfig()
{
- Relation.RelationKind kind = null;
-
- if (!options.get(column).isEmpty())
- {
- List<Relation.RelationKind> possible = options.get(column);
- int chosen = random.nextInt(possible.size());
- kind = possible.remove(chosen);
-
- if (kind == Relation.RelationKind.EQ)
- possible.clear(); // EQ precludes LT and GT
- else
- possible.remove(Relation.RelationKind.EQ); // LT GT preclude EQ
- }
+ return (cfg) -> {
+ cfg.set("row_cache_size", "50MiB")
+ .set("index_summary_capacity", "50MiB")
+ .set("counter_cache_size", "50MiB")
+ .set("key_cache_size", "50MiB")
+ .set("file_cache_size", "50MiB")
+ .set("index_summary_capacity", "50MiB")
+ .set("memtable_heap_space", "128MiB")
+ .set("memtable_offheap_space", "128MiB")
+ .set("memtable_flush_writers", 1)
+ .set("concurrent_compactors", 1)
+ .set("concurrent_reads", 5)
+ .set("concurrent_writes", 5)
+ .set("compaction_throughput_mb_per_sec", 10)
+ .set("hinted_handoff_enabled", false);
+ };
+ }
- return kind;
+ protected InJvmDTestVisitExecutor.PageSizeSelector
pageSizeSelector(EntropySource rng)
+ {
+ // Chosing a fetch size has implications for how well this test will
excercise paging, short-read protection, and
+ // other important parts of the distributed query apparatus. This
should be set low enough to ensure a significant
+ // number of queries during validation page, but not too low that more
expesive queries time out and fail the test.
+ return lts -> rng.nextInt(1, 10);
Review Comment:
I'd suggest something like [1, 20] to keep the mean around 10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
