dcapwell commented on code in PR #3689:
URL: https://github.com/apache/cassandra/pull/3689#discussion_r1848837035
##########
test/distributed/org/apache/cassandra/fuzz/sai/MultiNodeSAITest.java:
##########
@@ -18,18 +18,66 @@
package org.apache.cassandra.fuzz.sai;
+import org.junit.Before;
import org.junit.BeforeClass;
-public class MultiNodeSAITest extends MultiNodeSAITestBase
+import org.apache.cassandra.distributed.Cluster;
+import org.apache.cassandra.distributed.test.sai.SAIUtil;
+import org.apache.cassandra.harry.SchemaSpec;
+
+import static org.apache.cassandra.distributed.api.Feature.GOSSIP;
+import static org.apache.cassandra.distributed.api.Feature.NETWORK;
+
+public class MultiNodeSAITest extends SingleNodeSAITest
{
@BeforeClass
public static void before() throws Throwable
{
- MultiNodeSAITestBase.before(false);
+ cluster = Cluster.build()
+ .withNodes(2)
+ // At lower fetch sizes, queries w/ hundreds or
thousands of matches can take a very long time.
+ .withConfig(defaultConfig().andThen(c ->
c.set("range_request_timeout", "180s")
+
.set("read_request_timeout", "180s")
+
.set("native_transport_timeout", "180s")
+
.set("slow_query_log_timeout", "180s")
+
.with(GOSSIP).with(NETWORK)))
+ .createWithoutStarting();
+ cluster.setUncaughtExceptionsFilter(t -> {
+ logger.error("Caught exception, reporting during shutdown.
Ignoring.", t);
+ return true;
+ });
Review Comment:
cc @maedhroz
it might be pre-existing but it masks bugs. The supported pattern is to
exclude bugs we know about and don't wish to cause the test to fail, but to
ignore all bugs is way too broad...
If @maedhroz approves keeping it we can for the SAI tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
