lukasz-antoniak commented on PR #1983: URL: https://github.com/apache/cassandra-java-driver/pull/1983#issuecomment-2488177565
Declared Guava as a dependency to core module. Changes pushed. @absurdfarce, @adutra: I still have a problem with `OsgiShadedIT`. Our OSGi test project (_src/main/java/com/datastax/oss/driver/api/osgi_) uses mapper and query builder. Those two modules do not have shaded versions and they depend on Guava (mapper runtime could skip Guava dependency, but inside query builder it is more widely used). Previously they both included shaded Guava as a dependency. I could not remove Guava bundle from `OsgiShadedIT`. Tested locally that when I remove all dependencies for mapper runtime and query builder from test project, shaded core driver does not require Guava. I have tried to implement a new test and use Pax Exam to create OSGi bundle from *only part of test project* (include only classes that do not import `com.datastax.oss.driver.api.mapper`), but not sure if it is possible. We could create a test like this with completely new Maven module, but not sure if it is worth the effort. What is you view on the issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
