martin-sucha commented on code in PR #1785:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1785#discussion_r1850049214
##########
helpers.go:
##########
@@ -331,21 +331,27 @@ func (iter *Iter) RowData() (RowData, error) {
values := make([]interface{}, 0, len(iter.Columns()))
for _, column := range iter.Columns() {
- if c, ok := column.TypeInfo.(TupleTypeInfo); !ok {
- val, err := column.TypeInfo.NewWithError()
- if err != nil {
- return RowData{}, err
- }
+ if column.Name == "rack" && column.Keyspace == "system" &&
(column.Table == "peers_v2" || column.Table == "peers") {
Review Comment:
This seems like a hack, plus it could break backwards compatibility for
existing users of `RowData` (outside of gocql) that read from those tables.
Could the issue be fixed another way, for example improving the API/adding
new API for all users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
