dcapwell commented on code in PR #3689:
URL: https://github.com/apache/cassandra/pull/3689#discussion_r1850891862
##########
test/unit/org/apache/cassandra/cql3/ast/Select.java:
##########
@@ -60,25 +60,26 @@ public class Select implements Statement
public final Optional<OrderBy> orderBy;
public final Optional<Value> limit;
public final boolean allowFiltering;
-
+ public final boolean insertNewLine;
Review Comment:
I want to soften what I mean by "blocking comment" here... Alex and I spoke
in slack and I stated that most of my comments are suggestions and are
non-blocking comments, if we disagree his view wins. I said I would be
explicit about what is blocking (as the default isn't) but then this comes off
very harsh...
My concerns here is putting the string formatting state into the object
rather than providing it to the `toCQL` directly... I am open to other proposals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
