maulin-vasavada commented on code in PR #3638:
URL: https://github.com/apache/cassandra/pull/3638#discussion_r1851138548
##########
test/distributed/org/apache/cassandra/distributed/test/AbstractEncryptionOptionsImpl.java:
##########
@@ -70,11 +70,16 @@ public class AbstractEncryptionOptionsImpl extends
TestBaseImpl
final static String validTrustStorePassword =
TlsTestUtils.SERVER_TRUSTSTORE_PASSWORD;
// Base configuration map for a valid keystore that can be opened
- final static Map<String,Object> validKeystore =
ImmutableMap.of("keystore", validKeyStorePath,
+ protected final static Map<String,Object> validKeystore =
ImmutableMap.of("keystore", validKeyStorePath,
"keystore_password", validKeyStorePassword,
"truststore", validTrustStorePath,
"truststore_password", validTrustStorePassword);
+ // Configuration for a valid PEM based keystore
+ final static Map<String, Object> validPEMKeystore =
ImmutableMap.of("ssl_context_factory", ImmutableMap.of("class_name",
"org.apache.cassandra.security.PEMBasedSslContextFactory"),
Review Comment:
Will remove it since for the testing it relies on javax properties for the
key/trust store which we can't use for PEM formatted keystores.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
