dcapwell commented on code in PR #3694:
URL: https://github.com/apache/cassandra/pull/3694#discussion_r1854290412
##########
src/java/org/apache/cassandra/service/accord/api/AccordRoutingKey.java:
##########
@@ -318,6 +319,119 @@ public long serializedSize(TokenKey key, int version)
}
}
+ // Allows the creation of a Range that is begin inclusive or end exclusive
for a given Token
+ public static final class MinTokenKey extends TokenKey
+ {
+ private static final long EMPTY_SIZE;
+
+ @Override
+ public Range asRange()
+ {
+ AccordRoutingKey before = token.isMinimum()
+ ? new SentinelKey(table, true)
+ : new MinTokenKey(table,
token.decreaseSlightly());
Review Comment:
honestly I feel that decrease/increase should prob go away with a change to
ranges to allow swapping inclusive/exclusive... I wouldn't want to do that in
this patch as a ton of that lives in accord-core... I would prob tackle that as
"handle all partitioners" patch or something...
In this patch I would keep using decrease/increase as its consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
