worryg0d commented on code in PR #1842: URL: https://github.com/apache/cassandra-gocql-driver/pull/1842#discussion_r1858190652
########## CHANGELOG.md: ########## @@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed +- Move lz4 Compressor into gocql package (CASSGO-32) Review Comment: I think it should be something like `Move lz4 compressor to lz4 package within the gocql module` ########## go.mod: ########## @@ -18,13 +18,17 @@ module github.com/gocql/gocql require ( - github.com/bitly/go-hostpool v0.0.0-20171023180738-a3a6125de932 // indirect - github.com/bmizerany/assert v0.0.0-20160611221934-b7ed37b82869 // indirect github.com/golang/snappy v0.0.3 github.com/hailocab/go-hostpool v0.0.0-20160125115350-e80d13ce29ed - github.com/kr/pretty v0.1.0 // indirect - github.com/stretchr/testify v1.3.0 // indirect + github.com/pierrec/lz4/v4 v4.1.8 Review Comment: As I see from lz4 [repo](https://github.com/pierrec/lz4/blob/v4.1.8/go.mod) for release 4.1.8 go version in `go.mod` is set to `1.14`, but in the gocql `go.mod` go version is set to `1.13`. Also, this PR bumps version of `github.com/stretchr/testify` from 1.7.0 to [1.9.0](https://github.com/stretchr/testify/blob/v1.9.0/go.mod) that requires go of version at least 1.17, The [1.7.0](https://github.com/stretchr/testify/blob/v1.7.0/go.mod) version only needs go 1.13. @joao-r-reis should this PR change the go version here due to removing lz4 submodule? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
