ifesdjeen commented on code in PR #3711:
URL: https://github.com/apache/cassandra/pull/3711#discussion_r1863371343


##########
src/java/org/apache/cassandra/service/accord/AccordSafeCommand.java:
##########
@@ -120,9 +121,9 @@ public Command original()
         return original;
     }
 
-    public SavedCommand.Writer diff()
+    public Journal.CommandUpdate change()

Review Comment:
   I have renamed to `update` for now, but I am not a big fan of it since it is 
also a verb. I have a follow-up patch that cleans it all up, hope this is OK 
for interim.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to