smiklosovic commented on code in PR #3374:
URL: https://github.com/apache/cassandra/pull/3374#discussion_r1874397423
##########
src/java/org/apache/cassandra/service/CassandraDaemon.java:
##########
@@ -291,7 +300,7 @@ protected void setup()
{
SystemKeyspace.snapshotOnVersionChange();
}
- catch (IOException e)
+ catch (Throwable e)
Review Comment:
because what it internally does is that it takes a snapshot and
`executeTask` in snapshot manager will ultimately throw `SnapshotException`
which is `RuntimeException`, not `IOException`. I do not want SnapshotManager
to throw checked exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
