smiklosovic commented on code in PR #3718:
URL: https://github.com/apache/cassandra/pull/3718#discussion_r1874736499
##########
src/java/org/apache/cassandra/cql3/statements/schema/CreateTableStatement.java:
##########
@@ -479,12 +479,21 @@ public String defaultCompactValueName()
}
}
+ public static TableMetadata.Builder parse(String cql, String keyspace,
String table, Types types, UserFunctions userFunctions)
Review Comment:
@blerer the original version of that method (which calls this one) is still
there. We just create this one in order to be able to specify custom keyspace
and table name with types and functions. If we parse CQL for old table, we just
want to be able to put there keyspace and table name etc for new table directly
upon parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
