bbotella commented on code in PR #156:
URL: https://github.com/apache/cassandra-sidecar/pull/156#discussion_r1876140589
##########
server/src/main/java/org/apache/cassandra/sidecar/db/schema/SidecarSchema.java:
##########
@@ -69,21 +71,21 @@ public SidecarSchema(Vertx vertx,
this.sidecarInternalKeyspace = sidecarInternalKeyspace;
this.cqlSessionProvider = cqlSessionProvider;
this.metrics = metrics;
- if (this.schemaKeyspaceConfiguration.isEnabled())
- {
- configureSidecarServerEventListeners();
- }
- else
+ configureSidecarServerEventListenersMaybe();
+ }
+
+ private void configureSidecarServerEventListenersMaybe()
+ {
+ if (!this.schemaKeyspaceConfiguration.isEnabled())
{
LOGGER.info("Sidecar schema is disabled!");
Review Comment:
Nit: Maybe being more descriptive with the logger message? I think we could
answer the question: "so what?". In this case, what do you think about
something like: `Sidecar schema is disabled. Skipping configuring the sidecar
event listeners`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
