frankgh commented on code in PR #161:
URL: https://github.com/apache/cassandra-sidecar/pull/161#discussion_r1880921285
##########
server/src/main/java/org/apache/cassandra/sidecar/cluster/InstancesMetadataImpl.java:
##########
@@ -33,19 +33,19 @@
/**
* Local implementation of InstancesConfig.
*/
-public class InstancesConfigImpl implements InstancesConfig
+public class InstancesMetadataImpl implements InstancesMetadata
Review Comment:
update javadoc above as well
##########
server/src/test/integration/org/apache/cassandra/sidecar/testing/CassandraSidecarTestContext.java:
##########
@@ -228,23 +228,23 @@ public String toString()
@Override
public void close()
{
- if (instancesConfig != null)
+ if (instancesMetadata != null)
{
- instancesConfig.instances().forEach(instance ->
instance.delegate().close());
+ instancesMetadata.instances().forEach(instance ->
instance.delegate().close());
}
}
private void setInstancesConfig()
{
- this.instancesConfig = buildInstancesConfig(versionProvider,
dnsResolver);
+ this.instancesMetadata = buildInstancesConfig(versionProvider,
dnsResolver);
for (InstanceConfigListener listener : instanceConfigListeners)
{
- listener.onInstancesConfigChange(this.instancesConfig);
+ listener.onInstancesConfigChange(this.instancesMetadata);
}
}
- private InstancesConfig buildInstancesConfig(CassandraVersionProvider
versionProvider,
- DnsResolver dnsResolver)
+ private InstancesMetadata buildInstancesConfig(CassandraVersionProvider
versionProvider,
Review Comment:
```suggestion
private InstancesMetadata
buildInstancesMetadata(CassandraVersionProvider versionProvider,
```
##########
server/src/main/java/org/apache/cassandra/sidecar/server/MainModule.java:
##########
@@ -476,14 +476,14 @@ public DriverUtils driverUtils()
@Provides
@Singleton
- public InstancesConfig instancesConfig(Vertx vertx,
- SidecarConfiguration configuration,
- CassandraVersionProvider
cassandraVersionProvider,
- SidecarVersionProvider
sidecarVersionProvider,
- DnsResolver dnsResolver,
- CQLSessionProvider
cqlSessionProvider,
- DriverUtils driverUtils,
- MetricRegistryFactory
registryProvider)
+ public InstancesMetadata instancesConfig(Vertx vertx,
Review Comment:
rename the method as well
```suggestion
public InstancesMetadata instancesMetadata(Vertx vertx,
```
##########
server/src/test/integration/org/apache/cassandra/sidecar/testing/CassandraSidecarTestContext.java:
##########
@@ -184,21 +184,21 @@ public void setSslConfiguration(SslConfiguration
sslConfiguration)
refreshInstancesConfig();
}
- public InstancesConfig instancesConfig()
+ public InstancesMetadata instancesConfig()
{
- if (instancesConfig == null)
+ if (instancesMetadata == null)
{
refreshInstancesConfig();
}
- return this.instancesConfig;
+ return this.instancesMetadata;
}
- public InstancesConfig refreshInstancesConfig()
+ public InstancesMetadata refreshInstancesConfig()
Review Comment:
```suggestion
public InstancesMetadata refreshInstancesMetadata()
```
##########
server/src/test/integration/org/apache/cassandra/sidecar/testing/CassandraSidecarTestContext.java:
##########
@@ -184,21 +184,21 @@ public void setSslConfiguration(SslConfiguration
sslConfiguration)
refreshInstancesConfig();
}
- public InstancesConfig instancesConfig()
+ public InstancesMetadata instancesConfig()
Review Comment:
rename the method here too?
```suggestion
public InstancesMetadata instancesMetadata()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
