lukasz-antoniak commented on code in PR #1848:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1848#discussion_r1881934978
##########
query_executor.go:
##########
@@ -122,11 +126,11 @@ func (q *queryExecutor) executeQuery(qry ExecutableQuery)
(*Iter, error) {
case iter := <-results:
return iter, nil
case <-ctx.Done():
- return &Iter{err: ctx.Err()}, nil
+ return NewIterErr(qry, ctx.Err()), nil
}
}
-func (q *queryExecutor) do(ctx context.Context, qry ExecutableQuery, hostIter
NextHost) *Iter {
+func (q *queryExecutor) do(ctx context.Context, qry ExecutableQuery, it *Iter,
hostIter NextHost) *Iter {
Review Comment:
Since we move "mutable" query execution attributes into `Iter`, I think it
does make sense to add it to the method chain that executes given query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
