smiklosovic commented on PR #3733: URL: https://github.com/apache/cassandra/pull/3733#issuecomment-2541273855
@manish-m-pillai if you accept this change then we can start to build this patch in CI https://github.com/instaclustr/cassandra/commit/1afdbe610eeb3a095fd09f7df4b72f102c225cac What I did was that SortBy enum takes default sorting direction and then it implements abstract method which is sorting. Then you can just take sortBy and sort very comfortably by one line. What I like the most is that we are logically coupling sorting logic to respective sorting enum. Currently we do have an enum, but methods are separated from that and it is more complex than it could be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
