dcapwell commented on code in PR #3743:
URL: https://github.com/apache/cassandra/pull/3743#discussion_r1884692070
##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -1249,14 +1251,17 @@ public CompactionInfo getCompactionInfo()
Int2ObjectHashMap<RedundantBefore> redundantBefores = new
Int2ObjectHashMap<>();
Int2ObjectHashMap<DurableBefore> durableBefores = new
Int2ObjectHashMap<>();
Int2ObjectHashMap<RangesForEpoch> ranges = new Int2ObjectHashMap<>();
-
AsyncChains.getBlockingAndRethrow(node.commandStores().forEach(safeStore -> {
- synchronized (redundantBefores)
- {
- redundantBefores.put(safeStore.commandStore().id(),
safeStore.redundantBefore());
- ranges.put(safeStore.commandStore().id(), safeStore.ranges());
- durableBefores.put(safeStore.commandStore().id(),
safeStore.durableBefore());
- }
- }));
+ if (node.commandStores().all().length > 0)
Review Comment:
in my tests we are testing journal but we don't have any tables marked for
accord, so we had 0 stores... compaction tests were also impacted as we could
have data but due to us dropping accord we no longer have stores
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
