bbotella commented on code in PR #3748:
URL: https://github.com/apache/cassandra/pull/3748#discussion_r1887676311
##########
src/java/org/apache/cassandra/service/snapshot/TableSnapshot.java:
##########
@@ -377,7 +383,21 @@ public boolean equals(Object o)
return Objects.equals(keyspaceName, snapshot.keyspaceName) &&
Objects.equals(tableName, snapshot.tableName) &&
Objects.equals(tableId, snapshot.tableId) &&
- Objects.equals(tag, snapshot.tag);
+ tagsEqual(tag, snapshot.tag);
+ }
+
+ private boolean tagsEqual(String tag1, String tag2)
+ {
+ if (tag1 == null && tag2 == null)
+ return true;
+
+ if (tag1 == null || tag2 == null)
+ return false;
+
+ if (PLATFORM == PlatformEnum.MACOS)
+ return
LocalizeString.toLowerCaseLocalized(tag1).equals(LocalizeString.toLowerCaseLocalized(tag2));
Review Comment:
Nit: I think this is one of those places that would benefit from a comment
stating why we treat Mac differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
