bbotella commented on code in PR #166:
URL: https://github.com/apache/cassandra-sidecar/pull/166#discussion_r1898000040
##########
client/src/testFixtures/java/org/apache/cassandra/sidecar/client/SidecarClientTest.java:
##########
@@ -1573,6 +1575,36 @@ public void onError(Throwable throwable)
assertThat(new String(baos.toByteArray(),
StandardCharsets.UTF_8)).isEqualTo("Test Content");
}
+ @Test
+ public void testStreamsStats() throws Exception
+ {
+ String streamStatsResponseAsString = "{\"operationMode\":\"NORMAL\"," +
+
"\"streamProgressStats\":{\"totalFilesToReceive\":7," +
+
"\"totalFilesReceived\":7,\"totalBytesToReceive\":15088," +
Review Comment:
These numbers make me wonder if it would be worth to consider adding [Quick
Theories](https://github.com/quicktheories/QuickTheories) testing library to
sidecar like we have in Cassandra. I could see the case of leaving that out of
this PR, but it would definitely increase coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
