bbotella commented on code in PR #3729: URL: https://github.com/apache/cassandra/pull/3729#discussion_r1898607574
########## doc/modules/cassandra/pages/developing/cql/SASI.adoc: ########## @@ -519,7 +519,7 @@ execution. During the analysis phase, https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/index/sasi/plan/QueryPlan.java[`QueryPlan`] -converts from Cassandra's internal representation of `IndexExpression`s, +converts from Cassandra's internal representation of ``IndexExpression``s, Review Comment: Same for this one. Please check all around. ########## doc/modules/cassandra/pages/developing/cql/SASI.adoc: ########## @@ -405,15 +405,15 @@ or more page-sized blocks. The https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java[`OnDiskIndex`] is structured as a tree of arrays, where each level describes the terms in the level below, the final level being the terms themselves. The -`PointerLevel`s and their `PointerBlock`s contain terms and pointers to +``PointerLevel``s and their ``PointerBlock``s contain terms and pointers to Review Comment: This is leaving the `` `s `` out of the highlight. <img width="608" alt="Captura de pantalla 2024-12-27 a la(s) 8 22 10 a m" src="https://github.com/user-attachments/assets/9fac25c9-0005-4687-b840-c0e9efd69c17"; /> ########## doc/modules/cassandra/pages/developing/cql/SASI.adoc: ########## @@ -9,7 +9,7 @@ has superior performance in cases where queries would previously require filtering. In achieving this performance, SASI aims to be significantly less resource intensive than existing implementations, in memory, disk, and CPU usage. In addition, SASI supports prefix and contains queries on -strings (similar to SQL's `LIKE = "foo*"` or `LIKE = "*foo*"'`). +strings (similar to SQL's ``LIKE = "foo\*"`` or ``LIKE = "*foo*"`` ). Review Comment: Weirdly enough, my IntelliJ renderer is rendering the `` ` `` (single) and the `` ` ` ``(double) are rendered the same. Is that expected? If that's the case, we should keep consistency (at line 4, I can see the word `Index` wrapped by a single ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
