frankgh commented on code in PR #3728:
URL: https://github.com/apache/cassandra/pull/3728#discussion_r1901031526
##########
test/unit/org/apache/cassandra/audit/AuditLoggerTest.java:
##########
@@ -758,6 +790,108 @@ public void testJMXArchiveCommand() throws IOException
assertEquals("/xyz/not/null",
AuditLogManager.instance.getAuditLogOptions().archive_command);
}
+ @Test
+ public void testJMXAuditLogs() throws Throwable
+ {
+ // Need to use distinct ports, otherwise would get RMI registry object
ID collision, even with server shutdown between
+ testJMXAuditLogs(false,
getAutomaticallyAllocatedPort(InetAddress.getLoopbackAddress()));
Review Comment:
I think the benefit is that the code already exists under the test code, and
that we avoid duplication. However since the existing method doesn't fit
exactly the requirement, I think it's fine to keep the new method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
