tatu-at-datastax commented on PR #1988: URL: https://github.com/apache/cassandra-java-driver/pull/1988#issuecomment-2568096936
> Thank you for the fix! Makes sense to me. [Another outstanding PR](https://github.com/apache/cassandra-java-driver/pull/1644) is also about `Objects.hash()` Object[] allocation performance issues discovered by profiling. It makes me wonder what else `Objects.hash()` we should fix. We have a lot of `Objects.hash()` in our codebase. Interesting & good question. I think most of those cases do not probably matter that much (not in hot path of code flow) so it might be ok to change only cases that show up in profiling? Then again it might not be bad idea to have a look at how many other cases exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
