absurdfarce commented on code in PR #2001:
URL: 
https://github.com/apache/cassandra-java-driver/pull/2001#discussion_r1901280951


##########
driver-dist/pom.xml:
##########
@@ -145,10 +138,15 @@
                         </algorithms>
                       </configuration>
                     </plugin>
+                    <plugin>
+                        <artifactId>maven-gpg-plugin</artifactId>
+                        <configuration>
+                            <skip>false</skip>
+                        </configuration>
+                    </plugin>

Review Comment:
   Note: this change (and the change above) are necessary to fix a follow-on 
issue observed after the "basedir... does not exist" issue was resolved by the 
change below:
   
   ```
   [INFO] [INFO] --- javadoc:3.0.1:jar (attach-javadocs) @ 
cassandra-driver-dist ---
   [INFO] [INFO] 
   [INFO] [INFO] --- gpg:1.5:sign (sign-release-artifacts) @ 
cassandra-driver-dist ---
   [INFO] [INFO] 
------------------------------------------------------------------------
   [INFO] [INFO] Reactor Summary for Java Driver for Apache Cassandra 
3.11.6-SNAPSHOT:
   [INFO] [INFO] 
   [INFO] [INFO] Java Driver for Apache Cassandra ................... SUCCESS [ 
 2.041 s]
   [INFO] [INFO] Java Driver for Apache Cassandra - Core ............ SUCCESS [ 
18.895 s]
   [INFO] [INFO] Java Driver for Apache Cassandra - Object Mapping .. SUCCESS [ 
 9.554 s]
   [INFO] [INFO] Java Driver for Apache Cassandra - Extras .......... SUCCESS [ 
 6.934 s]
   [INFO] [INFO] Java Driver for Apache Cassandra - Examples ........ SUCCESS [ 
 3.299 s]
   [INFO] [INFO] Java Driver for Apache Cassandra Tests ............. SUCCESS [ 
 0.419 s]
   [INFO] [INFO] Java Driver for Apache Cassandra Tests - Stress .... SUCCESS [ 
 1.742 s]
   [INFO] [INFO] Java Driver for Apache Cassandra Tests - OSGi ...... SUCCESS [ 
 0.081 s]
   [INFO] [INFO] Java Driver for Apache Cassandra Tests - OSGi - Shaded SUCCESS 
[  1.009 s]
   [INFO] [INFO] Java Driver for Apache Cassandra Tests - OSGi - Shaded SUCCESS 
[  1.175 s]
   [INFO] [INFO] Java Driver for Apache Cassandra Tests - OSGi - Unshaded 
SUCCESS [  1.068 s]
   [INFO] [INFO] Java Driver for Apache Cassandra Tests - Shading ... SUCCESS [ 
 0.398 s]
   [INFO] [INFO] Java Driver for Apache Cassandra Tests - Shading - Shaded 
SUCCESS [  0.655 s]
   [INFO] [INFO] Java Driver for Apache Cassandra Tests - Shading - Unshaded 
SUCCESS [  0.652 s]
   [INFO] [INFO] Apache Cassandra Java Driver - source distribution . SUCCESS [ 
 0.911 s]
   [INFO] [INFO] Java Driver for Apache Cassandra - Binary distribution FAILURE 
[  0.623 s]
   [INFO] [INFO] 
------------------------------------------------------------------------
   [INFO] [INFO] BUILD FAILURE
   [INFO] [INFO] 
------------------------------------------------------------------------
   [INFO] [INFO] Total time:  50.299 s
   [INFO] [INFO] Finished at: 2024-12-26T13:41:48+01:00
   [INFO] [INFO] 
------------------------------------------------------------------------
   [INFO] [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-gpg-plugin:1.5:sign (sign-release-artifacts) on 
project cassandra-driver-dist: The project artifact has not been assembled yet. 
Please do not invoke this goal before the lifecycle phase "package". -> [Help 1]
   [INFO] [ERROR] 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to